[Lldb-commits] [PATCH] D143842: [lldb][test] Add check for Xcode binutils version to test-runner

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

Should we put something like

  #if DARWIN
  STRIP=$(shell xcrun -find strip)
  #else
  STRIP=strip
  #fi

in Makefile.rules instead?



================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:889
+toolchain. Please make sure the Xcode tools are before any
+other tools in your path. Run `xcode -f strip` for the correct
+toolchain path.
----------------
Michael137 wrote:
> tschuett wrote:
> > Did you mean `xcrun -f strip`?
> yup! good catch
I would use `xcrun -find strip` for more clarity


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143842/new/

https://reviews.llvm.org/D143842