[Lldb-commits] [lldb] 8a57748 - Revert "[lldb][Test][NFC] TestExternalCtorDtorLookup: add more instantiations to test linkage name is correct"

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 13 10:09:55 PST 2023


Author: Michael Buch
Date: 2023-02-13T18:09:31Z
New Revision: 8a57748804bd2247a8c0c5632af3364db58a087f

URL: https://github.com/llvm/llvm-project/commit/8a57748804bd2247a8c0c5632af3364db58a087f
DIFF: https://github.com/llvm/llvm-project/commit/8a57748804bd2247a8c0c5632af3364db58a087f.diff

LOG: Revert "[lldb][Test][NFC] TestExternalCtorDtorLookup: add more instantiations to test linkage name is correct"

This reverts commit 3c160d3051dc5d637bd35cfa673871338589ad8e.

This patch depends on the reverted patch in https://reviews.llvm.org/D143652

Differential Revision: https://reviews.llvm.org/D143652

Added: 
    

Modified: 
    lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
    lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
    lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp

Removed: 
    lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.cpp


################################################################################
diff  --git a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
index 3e4cfc7e8256..eba15476332f 100644
--- a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
+++ b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
@@ -1,3 +1,3 @@
-CXX_SOURCES := main.cpp lib.cpp
+CXX_SOURCES := main.cpp
                        
 include Makefile.rules 

diff  --git a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.cpp b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.cpp
deleted file mode 100644
index f1724b73bdce..000000000000
--- a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.cpp
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "lib.h"
-
-Wrapper<Foo> getFooWrapper() { return {}; }

diff  --git a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
index 1fee83fb115a..9664068b6e14 100644
--- a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
+++ b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
@@ -8,8 +8,5 @@ template <typename T> class Wrapper {
   [[gnu::abi_tag("test")]] ~Wrapper(){};
 };
 
-struct Foo {};
-
-Wrapper<Foo> getFooWrapper();
-
 #endif // _H_IN
+

diff  --git a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp
index e1caf0202d97..3904646c05db 100644
--- a/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp
+++ b/lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp
@@ -1,5 +1,7 @@
 #include "lib.h"
 
+struct Foo {};
+
 struct Bar {
   Wrapper<Foo> getWrapper() { return Wrapper<Foo>(); }
   int sinkWrapper(Wrapper<Foo>) { return -1; }
@@ -7,10 +9,6 @@ struct Bar {
 
 int main() {
   Bar b;
-  Wrapper<int> w1;
-  Wrapper<double> w2;
-  Wrapper<Foo> w3 = getFooWrapper();
-  Wrapper<Foo> w4;
   return b.sinkWrapper(b.getWrapper());
 }
 


        


More information about the lldb-commits mailing list