[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D142926#4116427 <https://reviews.llvm.org/D142926#4116427>, @clayborg wrote:

> Does this mean we could submit a patch that removes all of the "LLDB_INSTRUMENT*" stuff that is in all of the SB*.cpp files? That would be great to clean that up if they are not needed.

No, they are still needed. They still track API boundaries, just like they did for the reproducers. The API boundaries are used for the API log and for timers/os_signposts. What they do is make sure that when you call into the SB API and the implementation of that SB API method calls another SB API, only the outer one will show up in the log. The macros also ensure that every function is correctly logged. Before the macros, half of the methods didn't log to the API log and the ones that did were riddled with inconsistencies (typos, copy-paste errors, etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142926/new/

https://reviews.llvm.org/D142926