[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D142926#4111717 <https://reviews.llvm.org/D142926#4111717>, @bulbazord wrote:

> In addition to what I wrote above, I also fixed several documentation bugs (putting docstrings on the wrong method).
>
> I manually audited the generated code before and after this change. Here are my notes:
>
> Not too interesting:
>
> - Some parameter names changed
> - Fixed lots of documentation bugs
> - Some documentation changed because of a re-ordering of function declarations
>
> Potentially interesting:
>
> - SBData::GetDescription base_addr parameter has default value now
> - SBInstructionList::GetInstructionsCount canSetBreakpoint has default value now
> - SBMemoryRegionInfo::SBMemoryRegionInfo 3rd constructor parameter stack_memory has default value now
>
> Certainly interesting:
>
> - SBListener::StopListeningForEventClass return type conflicts (ABI break?)

No, probably a copy paste error when originally checked into .i file?

> - SBProcess::GetQueueAtIndex parameter types conflict (ABI break?)

No, probably a copy paste error when originally checked into .i file?

> - SBTarget::BreakpointCreateByNames first parameter is different: `const char **symbol_name` vs `const char *symbol_name[]`. I'm not sure if this is going to be an issue.

Maybe SWIG didn't like the "const char **" or it didn't do the right thing? Test and verify if we switch to using the header file we have no issues please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142926/new/

https://reviews.llvm.org/D142926