[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61
 
         if self.expectedCompilerVersion(['>', '16.0']):
+            string_type = "std::string"
----------------
aprantl wrote:
> Out of curiosity: How does this function work when building the testsuite with a compiler that isn't Clang?
> I vaguely recall there was someone in the community running a bot that built the LLDB testsuite against GCC.
Good point, this should also check for the compiler really. I assume because GCC isn't at that version yet it just works on that GCC buildbot

Will change in a different patch since there's other tests with this condition


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143501/new/

https://reviews.llvm.org/D143501