[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

In addition to what I wrote above, I also fixed several documentation bugs (putting docstrings on the wrong method).

I manually audited the generated code before and after this change. Here are my notes:

Not too interesting:

- Some parameter names changed
- Fixed lots of documentation bugs
- Some documentation changed because of a re-ordering of function declarations

Potentially interesting:

- SBData::GetDescription base_addr parameter has default value now
- SBInstructionList::GetInstructionsCount canSetBreakpoint has default value now
- SBMemoryRegionInfo::SBMemoryRegionInfo 3rd constructor parameter stack_memory has default value now

Certainly interesting:

- SBListener::StopListeningForEventClass return type conflicts (ABI break?)
- SBProcess::GetQueueAtIndex parameter types conflict (ABI break?)
- SBTarget::BreakpointCreateByNames first parameter is different: `const char **symbol_name` vs `const char *symbol_name[]`. I'm not sure if this is going to be an issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142926/new/

https://reviews.llvm.org/D142926