[Lldb-commits] [PATCH] D143232: Return an error when the CFA resolves to no known register, instead of segfaulting

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

In D143232#4101396 <https://reviews.llvm.org/D143232#4101396>, @bulbazord wrote:

> LGTM. I wonder if there's a good way to exercise this with a test? Like maybe we can create some bogus unwind information and see if LLDB falls over when consuming it?

I'm not sure how we could do that tbh - the currently executing frame uses an unwind plan sourced from the assembly instructions, and I can't construct assembly language that lldb would parse as using an invalid register number to calculate the canonical frame address.  (I genuinely have no idea how we're hitting this codepath; it should not be possible.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143232/new/

https://reviews.llvm.org/D143232