[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:1148
+class CrashLogLoadingMode(str, enum.Enum):
+    legacy = 'legacy'
+    interactive = 'interactive'
----------------
This can be interpreted as the textual crashlogs going away which isn't the case or the goal. I think this should say "textual" (although that might be confusing with the JSON/text input) or maybe "batch".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141658/new/

https://reviews.llvm.org/D141658