[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

Fri Jan 27 10:29:26 PST 2023

ayermolo marked 2 inline comments as done.
ayermolo added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32

-  DIERef(std::optional<uint32_t> dwo_num, Section section,
+  DIERef(std::optional<uint32_t> dwo_oso_num, Section section,
          dw_offset_t die_offset)
----------------
labath wrote:
> ayermolo wrote:
> > labath wrote:
> > > Where is this constructor being used?
> > In SymbolFileDWARF.cpp
> > SymbolFileDWARF::GetUID
> > SymbolFileDWARF::DecodeUID
> I'm sorry, I must have clicked the wrong line. My question was about the constructor below this (line 40).
Ah yes, sorry. Removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139957/new/

https://reviews.llvm.org/D139957