[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32
 
-  DIERef(std::optional<uint32_t> dwo_num, Section section,
+  DIERef(std::optional<uint32_t> dwo_oso_num, Section section,
          dw_offset_t die_offset)
----------------
ayermolo wrote:
> labath wrote:
> > Where is this constructor being used?
> In SymbolFileDWARF.cpp
> SymbolFileDWARF::GetUID
> SymbolFileDWARF::DecodeUID
I'm sorry, I must have clicked the wrong line. My question was about the constructor below this (line 40).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139957/new/

https://reviews.llvm.org/D139957