[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

Joe Loser via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 16 13:51:39 PST 2023


jloser added inline comments.


================
Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652
 
   auto data =
+      llvm::MutableArrayRef(static_cast<uint8_t *>(buf), bytes_read);
----------------
serge-sans-paille wrote:
> random nit: This could be rewritten as
> 
> ```
> llvm::MutableArrayRef data(static_cast<uint8_t *>(buf), bytes_read);
> ```
> 
> now
Yep, I just changed that before landing this. Thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141814/new/

https://reviews.llvm.org/D141814



More information about the lldb-commits mailing list