[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

[Daniel Kiss via Phabricator via lldb-commits]

danielkiss added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:532
     getTargetDefinesARMV81A(Opts, Builder);
-    break;
-  case llvm::AArch64::ArchKind::ARMV8_2A:
+  if (*ArchInfo == llvm::AArch64::ARMV8_2A)
     getTargetDefinesARMV82A(Opts, Builder);
----------------



================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:172
+       *ArchInfo == llvm::AArch64::ARMV9_1A ||
+       *ArchInfo == llvm::AArch64::ARMV9_2A)) {
     Features.push_back("+sve");
----------------
Would be nice to add a custom operator to `ArchInfo` to say `*ArchInfo >= llvm::AArch64::ARMV9A`
because it looks to me here the `llvm::AArch64::ARMV9_3A` and `llvm::AArch64::ARMV9_4A` are missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792