[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

[Lucas Prates via Phabricator via lldb-commits]

pratlucas accepted this revision.
pratlucas added a comment.

LGTM with a tiny nit. Feel free to fix it when landing the changes.



================
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:164-166
+  CPUFeatures CPUFeature;      // ?????
+  StringRef DependentFeatures; // ?????
+  unsigned FmvPriority;        // ?????
----------------
Minor nit: can you replace the `// ?????` comments with a single TODO to document those better? It'd look a bit less confusing for others reading this in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792