[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

[Nico Weber via Phabricator via lldb-commits]

thakis added a comment.

Thanks for this change :)



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:141
 
-class WrapperOptTable : public opt::OptTable {
+class WrapperOptTable : public opt::GenericOptTable {
 public:
----------------
C


================
Comment at: llvm/include/llvm/Option/OptTable.h:257
+/// Specialization of OptTable
+class GenericOptTable : public OptTable {
+  SmallVector<StringLiteral> PrefixesUnionBuffer;
----------------
(nit, kind of too late now: I would've renamed the base class to `BaseOptTable` or what and kept `OptTable` for this one, so that all the tools wouldn't have to be touched at all.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140800/new/

https://reviews.llvm.org/D140800