[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 11 14:51:30 PST 2023


kastiglione added a comment.

I will add explicit tests for `p`.



================
Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:138
             self.dbg.SetOutputFileHandle(f, False)
-            self.handleCmd('p/x 3735928559', collect_result=False, check=False)
+            self.handleCmd('expression/x 3735928559', collect_result=False, check=False)
         with open(self.out_filename, 'r') as f:
----------------
aprantl wrote:
> not your code, but does the `/x` serve any purpose here?
a couple lines below they read in the output from this command, and compare hex 3735928559 to "deadbeef".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141539/new/

https://reviews.llvm.org/D141539



More information about the lldb-commits mailing list