[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Are you planning on updating the reverse disassembly code still on this patch?



================
Comment at: lldb/include/lldb/API/SBTarget.h:844
 
+  uint32_t GetMaximumOpcodeByteSize() const;
+
----------------
Do we still need this API change with the new approach? We can't really use this unless we include GetMinimumOpcodeByteSize() and only use this value to backup if the min and max are the same.


================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2183-2194
+  /**
+   * For negative offsets, we do not know what `start_addr` corresponds to the
+   * instruction located `instruction_offset` instructions before `base_addr`
+   * since on some architectures opcodes have variable length.
+   *
+   * To address that, we need to read at least starting from `start_addr =
+   * base_addr + instruction_offset * max_instruction_size` (pruning is done if
----------------
Use C++ comments instead of C style comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140358/new/

https://reviews.llvm.org/D140358