[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jan 1 11:34:42 PST 2023


serge-sans-paille added a comment.

In D140800#4021228 <https://reviews.llvm.org/D140800#4021228>, @thakis wrote:

> Could we make this an optional opt-in maybe? I imagine for the majority of the tools, this has no measurable effect, but it currently makes the Opt library harder to use for every client.

Sure, let's have two constructors, one that uses a precomputed table and one that does the precomputation.
Would you prefer having only clang use the faster-but-less efficient method, or can I keep the changes as is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140800/new/

https://reviews.llvm.org/D140800



More information about the lldb-commits mailing list