[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

[Alexander Yermolovich via Phabricator via lldb-commits]

ayermolo added inline comments.


================
Comment at: lldb/include/lldb/Utility/Status.h:65
+  template <typename... Args>
+  explicit Status(const char *format, Args &&...args) {
+    SetErrorToGenericError();
----------------
labath wrote:
> I don't think you've converted all the callers of this one. Given it's pervasiveness, I think we will need to do some sort of a staged conversion, to ensure call sites get compile errors instead of silent breakage. For now I think it would be fine to have a "named constructor" using formatv (`static Status Status::WithFormat(fmt, args...)`). Or just leave it out...
Yeah you are right, missed a bunch. :/ As an experiment changed Status constructor to take a string and caller side to std::string(llvm::formatv() After 26 files, gave up. Would have exploded this diff. Added a static function that constructs Status using formatv


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139955/new/

https://reviews.llvm.org/D139955