[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

I'm happy with the launching/attaching discussion resolved. Similar to the deduplication I think it makes more sense to tackle that first instead of landing this "as is" and then fixing it after the fact.



================
Comment at: lldb/bindings/python/python-wrapper.swig:317
 
+PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform(
+    const char *python_class_name, const char *session_dictionary_name,
----------------
mib wrote:
> JDevlieghere wrote:
> > This looks pretty similar to `LLDBSwigPythonCreateScriptedThread` and `LLDBSwigPythonCreateScriptedProcess`. Can we factor out the common parts?
> True, but this need some refactor unrelated to this patch, so I'll do it in a follow-up
Instead of adding a lot of duplicate code and factoring it out after, maybe it makes more sense to clean it up first and rebase this patch on top of that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139250/new/

https://reviews.llvm.org/D139250