[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

[Alexander Yermolovich via Phabricator via lldb-commits]

ayermolo added a comment.

In D138618#4004866 <https://reviews.llvm.org/D138618#4004866>, @labath wrote:

> You, if I understand correctly, see the ID of a symbol file as a special case of an all-encompassing user id -- essentially a user_id (or a DIERef) pointing to the first byte of the symbol file. with this world view, the entirety of user ID computation is a mess. :)

Ah I see. Thanks for providing context. Yeah that is kind of the way I see it after talking with Greg. Looking over your proposal it makes sense with the way you described how you see this. You and @clayborg  have a historical context for this code. He is on PTO right now, lets see what he thinks when he is back in a couple weeks? :)

In meantime what do you think about closing on D139955 <https://reviews.llvm.org/D139955>, so it can land? I think it is fully independent of design decision in this diff, and can land separately. Would be great to juggle one less diff on a stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138618/new/

https://reviews.llvm.org/D138618