[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional
Fangrui Song via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 19 13:18:23 PST 2022
MaskRay added a comment.
Can you push `using OptionalFileEntryRef = CustomizableOptional<FileEntryRef>;` and the renaming as a separate commit to make this patch smaller?
There is a smaller that this rename may be reverted.
205c0589f918f95d2f2c586a01bea2716d73d603 <https://reviews.llvm.org/rG205c0589f918f95d2f2c586a01bea2716d73d603> reverted a change related to `OptionalFileEntryRef`. I assume that your change is fine.
================
Comment at: mlir/include/mlir/IR/Visitors.h:49
bool operator==(const WalkResult &rhs) const { return result == rhs.result; }
+ bool operator!=(const WalkResult &rhs) const { return result != rhs.result; }
----------------
Can be pushed separately
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140332/new/
https://reviews.llvm.org/D140332
More information about the lldb-commits
mailing list