[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 19 01:25:55 PST 2022


DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

> If you just run ninja check-lldb prior to this patch libLTO would not be built.

Great, put that in the commit message.

What I was trying to get at was the meaning of depends on:

- depends on thing, so we should build the thing
- depends on thing, so we shouldn't run the test if thing isn't present

And confirm that the former was your intent, but we do a lot of the latter elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140051/new/

https://reviews.llvm.org/D140051



More information about the lldb-commits mailing list