[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 19 01:07:55 PST 2022


labath accepted this revision.
labath added a comment.

That looks great. I have just one small nit. I think the test would read better if you made the names of temporary `TemplateArgument` objects more descriptive -- i.e. encode the kind and value information in the name. For example. `int47Arg` for an integer template argument whose value is 47, and `intTypeArg` for a type template argument (where `int` is the "value").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140030/new/

https://reviews.llvm.org/D140030



More information about the lldb-commits mailing list