[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 5 10:14:44 PST 2022
mib added inline comments.
================
Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:12-14
+#include "lldb/Host/Host.h"
+#include "lldb/Host/ProcessLaunchInfo.h"
+#include "lldb/Interpreter/OptionGroupPythonClassWithDict.h"
----------------
JDevlieghere wrote:
> These are layering violations. Host and Interpreter both depend on Utility. Regardless this class doesn't seem like a good fit for Utility anyway.
@JDevlieghere Do you think it'd make more sense to have it in the `Interpreter` directory ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139247/new/
https://reviews.llvm.org/D139247
More information about the lldb-commits
mailing list