[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic

Mon Dec 5 09:35:25 PST 2022

JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.

================
Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:12-14
+#include "lldb/Host/Host.h"
+#include "lldb/Host/ProcessLaunchInfo.h"
+#include "lldb/Interpreter/OptionGroupPythonClassWithDict.h"
----------------
These are layering violations. Host and Interpreter both depend on Utility. Regardless this class doesn't seem like a good fit for Utility anyway. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139247/new/

https://reviews.llvm.org/D139247