[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

In D138612#3950102 <https://reviews.llvm.org/D138612#3950102>, @jasonmolenda wrote:

> 



> I didn't look into this patch enough to say whether this is a real failure, or if the test assumes behavior that is only true with the accelerator tables used in DWARF on linux, the apple ones used on macOS.  In which case this may simply be a skipIfDarwin test, I don't know.

If this is a difference in behavior between the DWARF accelerator tables used on linux versus the apple accelerator tables used on macOS, it's an interesting question of whether this is pointing out a bug in the apple accelerator table support in lldb or something to do with how the tables are set up.  If you don't have access to a macOS system to investigate more closely, and you don't think this is indicating a bug or regression in behavior, then I think skipping the test for now on darwin is not unreasonable.  My two cents having not looked into any of these changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138612/new/

https://reviews.llvm.org/D138612