[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

Thu Nov 24 18:28:41 PST 2022

jasonmolenda added a comment.

In D138612#3950098 <https://reviews.llvm.org/D138612#3950098>, @aeubanks wrote:

> In D138612#3949869 <https://reviews.llvm.org/D138612#3949869>, @jasonmolenda wrote:
>
>> Hi Arthur, this change is causing a testsuite failure on Darwin systems - see https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48671/ on the "LLDB Incremental" bot - and I can reproduce this failure on my local mac.  Would you like to revert this until you've had a chance to find the issue, or should I?  It's a holiday weekend in the US & I would understand if you don't see this message for a while, I'll revert later today unless you suggest an alternative.  Thanks.
>
> Feel free to revert, but could you post the log file that the test looks at with and without the change?

The bot is also broken with Adrian Vogelsgesang's coroutines formatter right now and I was going to wait until tomorrow morning US time before I revert his patchsets, not sure which time zone he's in, so I won't do anything until then at least.

The bot has pretty good logs fwiw,

  FAIL: test_dwarf (TestCPPAccelerator.CPPAcceleratorTableTestCase)
     Test that type lookups fail early (performance)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1691, in test_method
      return attrvalue(self)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 159, in wrapper
      return func(*args, **kwargs)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/lang/cpp/accelerator-table/TestCPPAccelerator.py", line 32, in test
      self.assertEqual(n, 1, "".join(log))
  AssertionError: 0 != 1 :  (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x00000127, decl_ctx = 0x7fc72ebdb430 (die 0x0000000b)) DW_TAG_reference_type name = '(null)')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x0000012c, decl_ctx = 0x7fc72ebdb430 (die 0x0000000b)) DW_TAG_class_type name = 'D')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x00000142, decl_ctx = 0x7fc72ebdbca0 (die 0x0000012c)) DW_TAG_structure_type name = 'Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: SymbolFileDWARF(0x7fc72c4a7a50) - 0x00000142: DW_TAG_structure_type type "Inner" is a forward declaration, trying to find complete type
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/a.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/a.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner') trying die=0x00000061 (A::Inner)
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/b.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/b.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner') trying die=0x00000061 (B::Inner)
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/c.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/c.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner') trying die=0x00000061 (C::Inner)
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/d.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/d.o: SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(tag=DW_TAG_structure_type, name='Inner') trying die=0x00000061 (D::Inner)
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/d.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x0000004b, decl_ctx = 0x7fc72ebdb430 (die 0x0000000b)) DW_TAG_class_type name = 'D')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/d.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x00000061, decl_ctx = 0x7fc72ebdbca0 (die 0x0000004b)) DW_TAG_class_type name = 'Inner')
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/main.o: SymbolFileDWARF(0x7fc72c4a7a50) - 0x00000142: DW_TAG_structure_type type "Inner" is a forward declaration, complete type is 0x500000061
   (x86_64) /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/lang/cpp/accelerator-table/TestCPPAccelerator.test_dwarf/d.o: DWARFASTParserClang::ParseTypeFromDWARF (die = 0x0000007e, decl_ctx = 0x7fc72ebdb430 (die 0x0000000b)) DW_TAG_base_type name = 'int')

I didn't look into this patch enough to say whether this is a real failure, or if the test assumes behavior that is only true with the accelerator tables used in DWARF on linux, the apple ones used on macOS.  In which case this may simply be a skipIfDarwin test, I don't know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138612/new/

https://reviews.llvm.org/D138612