[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

[Alexey Lapshin via Phabricator via lldb-commits]

avl added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:82
+    /// Is this a reference to a DIE that hasn't been cloned yet?
+    bool Reference : 1;
   };
----------------
Probably name it UnclonedReference ? or RefShouldBePatched?(or something like that)


================
Comment at: llvm/lib/DWARFLinker/DWARFLinkerCompileUnit.cpp:79
 
 /// Keep track of a forward cross-cu reference from this unit
 /// to \p Die that lives in \p RefUnit.
----------------
/// Keep track of a cross-cu reference from this unit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138176/new/

https://reviews.llvm.org/D138176