[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

Thu Nov 17 06:06:37 PST 2022

labath added a comment.

In D137873#3933171 <https://reviews.llvm.org/D137873#3933171>, @alvinhochun wrote:

> I think the module spec of the modules should reflect the value of the `plugin.object-file.pe-coff.abi` setting. Can ProcessMinidump take the module spec of the executable module to use its target environment?

That's kinda what `Target::MergeArchitecture` is for.

> Mixing MSVC and MinGW DLLs is a tricky case so I will not be surprised if something doesn't work correctly. It would be nice to have it working but that would be outside the scope of this review. (I don't yet have a use case for this but I am getting close with some COM / WinRT experiments.)

Sounds fun. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137873/new/

https://reviews.llvm.org/D137873