[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 17 03:36:00 PST 2022


DavidSpickett added a comment.

What was the decision on `m_dwarf_cu` possibly being nullptr? We at least want asserts in paths where we assume it'll not be null.

Beyond that this seems fine but I'm not really into DWARF, @labath any comments?

Seems like quite a cheap fallback to add, and my assumption is that we don't find many unknown opcodes in general use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137247/new/

https://reviews.llvm.org/D137247



More information about the lldb-commits mailing list