[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

[Kazuki Sakamoto via Phabricator via lldb-commits]

splhack added a comment.

Either way works as long as we can pass the Android serial number to AdbClient.cpp.

This diff just followed the current code which is actually already working for USB-connected devices and emulator. So adding TCPIP-connected device support here makes sense.

  m_device_id = parsed_url->hostname.str();

If platform connect will accept platform-specific flags, potentially it may want these.

- --serial (Android serial number)
- --local-gdb-port (D136465 <https://reviews.llvm.org/D136465>)
- --local-port (D136465 <https://reviews.llvm.org/D136465>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138164/new/

https://reviews.llvm.org/D138164