[Lldb-commits] [lldb] 8d41609 - [lldb/test] Fix app_specific_backtrace_crashlog.test (NFC)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 15 14:26:00 PST 2022


Author: Med Ismail Bennani
Date: 2022-11-15T14:25:52-08:00
New Revision: 8d416099240a2c090bd461f99c3014bac828cf98

URL: https://github.com/llvm/llvm-project/commit/8d416099240a2c090bd461f99c3014bac828cf98
DIFF: https://github.com/llvm/llvm-project/commit/8d416099240a2c090bd461f99c3014bac828cf98.diff

LOG: [lldb/test] Fix app_specific_backtrace_crashlog.test (NFC)

This patch changes app_specific_backtrace_crashlog.test's crashlog file
extension from `ips` to `txt. This should prevent the test from opening
Console.app when being run.

This should also fix a test failure caused by missing symbols.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>

Added: 
    lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.txt

Modified: 
    lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test

Removed: 
    lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.ips


################################################################################
diff  --git a/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.ips b/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.txt
similarity index 100%
rename from lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.ips
rename to lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/application_specific_info/asi.txt

diff  --git a/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test b/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
index 5ca5c51a3125c..c57cefdaf32d2 100644
--- a/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
+++ b/lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
@@ -3,7 +3,7 @@
 # RUN: mkdir -p %t.dir
 # RUN: yaml2obj %S/Inputs/application_specific_info/asi.yaml > %t.dir/asi
 # RUN: %lldb -o 'command script import lldb.macosx.crashlog' \
-# RUN: -o 'crashlog -a -i -t %t.dir/asi %S/Inputs/application_specific_info/asi.ips' \
+# RUN: -o 'crashlog -a -i -t %t.dir/asi %S/Inputs/application_specific_info/asi.txt' \
 # RUN: -o "thread list" -o "bt all" 2>&1 | FileCheck %s
 
 # CHECK: "crashlog" {{.*}} commands have been installed, use the "--help" options on these commands
@@ -44,7 +44,7 @@
 # CHECK-NEXT:     frame #3: 0x00000001a0b46af3{{.*}}
 # CHECK-NEXT:     frame #4: 0x00000001a09a12a3{{.*}}
 # CHECK-NEXT:     frame #5: 0x00000001047e3ecf asi`main{{.*}}
-# CHECK-NEXT:     frame #6: 0x00000001a05d3e4f dyld`start{{.*}}
+# CHECK-NEXT:     frame #6: 0x00000001a05d3e4f
 
 
 # CHECK: (lldb) thread list


        


More information about the lldb-commits mailing list