[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h:90
   void Dump(Stream &stream);
+  static void RequireCompleteType(CompilerType type);
 
----------------
I forgot about this the first time around, but it'd be nice if this code could be shared between the pdb and dwarf plugins. Maybe by putting it into TypeSystemClang ?


================
Comment at: lldb/test/Shell/SymbolFile/NativePDB/incomplete-tag-type.cpp:20
+struct C {
+  static A static_a;
+  A getA() {}
----------------
Maybe you could leave this in (but change the test so that it expects the expression to fail)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134066/new/

https://reviews.llvm.org/D134066