[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu updated this revision to Diff 473829.
zequanwu added a comment.

Removed `PdbAstBuilder::RequireCompleteType` from `PdbAstBuilder::CreateArrayType` as it's not necessary at all.

1. When the element type info is missing, its size info is missing in pdb, which is 0. Thus we can't calculate the number of element in the array.
2. When the element type info is present, it will be completed later as needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134066/new/

https://reviews.llvm.org/D134066

Files:
  lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h
  lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp
  lldb/test/Shell/SymbolFile/NativePDB/Inputs/incomplete-tag-type.cpp
  lldb/test/Shell/SymbolFile/NativePDB/incomplete-tag-type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134066.473829.patch
Type: text/x-patch
Size: 5600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221108/97473ddf/attachment.bin>