[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing
Thorsten via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 26 23:50:47 PDT 2022
tschuett added inline comments.
================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:6264
major_version, minor_version, patch_version);
- if (platform) {
+ if (platform.has_value()) {
os_handled = true;
----------------
Nit: the `has_value()`is redundant. optional has boolean conversion.
================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:6266
os_handled = true;
- rep << "ostype:" << platform << ";";
+ rep << "ostype:" << platform.value() << ";";
break;
----------------
Maybe `*platform` works.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136719/new/
https://reviews.llvm.org/D136719
More information about the lldb-commits
mailing list