[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 26 17:01:48 PDT 2022


jasonmolenda updated this revision to Diff 470972.
jasonmolenda added a comment.

Update patch to pass std::string's in the optionals, and use std::nullopt.  Thanks for all the feedback on this one, Thorsten.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136719/new/

https://reviews.llvm.org/D136719

Files:
  lldb/tools/debugserver/source/DNB.cpp
  lldb/tools/debugserver/source/DNB.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.mm
  lldb/tools/debugserver/source/RNBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136719.470972.patch
Type: text/x-patch
Size: 6092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221027/f6f3f3d4/attachment.bin>


More information about the lldb-commits mailing list