[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

Tiezhu Yang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 25 04:25:40 PDT 2022


seehearfeel added a comment.

In D136578#3881955 <https://reviews.llvm.org/D136578#3881955>, @DavidSpickett wrote:

> This LGTM from the lldb side.

OK, thank you.

> Feel free to upload a series of patches in future if you want. You don't have to do one at a time, just update the whole stack as needed. Plus it gives the reviewers some context of what the changes are working towards.

I am a newcomer, here are some of my thoughts:
(1) Add the minimal changes to fix the build errors.
(2) Submit other more patches step by step to make
the basic command "run", "breakpoint", "next" ...
can be used to debug, single patch or patch series.
(3) Add more code to make more commands work well.

> Do you have commit access? If not it's fine to wait until you have (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access), or someone else can land on your behalf. Just provide a name and email address you'd like to be on the commit.

I have no commit access now, @SixWeining luweining at loongson.cn
can land on my behalf, here are my name and email:
Tiezhu Yang
yangtiezhu at loongson.cn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136578/new/

https://reviews.llvm.org/D136578



More information about the lldb-commits mailing list