[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

[Xi Ruoyao via Phabricator via lldb-commits]

xry111 added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26
+public:
+  struct GPR {
+    uint64_t gpr[32];
----------------
SixWeining wrote:
> Why is this structure and below `FPR` defined like this? Do you intent to keep the layout same as some structures of Linux? If yes, is it necessary?
It seems necessary because lldb invokes `ptrace` system call which directly stores into the pointer returned by `GetGPRBuffer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136578/new/

https://reviews.llvm.org/D136578