[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

Mon Oct 24 02:12:38 PDT 2022

DavidSpickett added a comment.

Always good to see another architecture in lldb.

A few points up front.

Changes like this are fine and we can review them, but can only be landed once we see that they'll be built on. So please stack changes so that we can see what is upcoming. https://llvm.org/docs/Phabricator.html#creating-a-patch-series

Do you have a plan to test this configuration? I don't see any public buildbots for Loongson (please correct me if I am wrong) but that is not a requirement as long as you have some testing plan (RISCV doesn't have a public bot, as one example).

Do you have community members who can review these changes for architectural correctness? Speaking just for myself I am happy to review bits of lldb machinery but when it comes to architecture details I am not, and will not, be an expert in Loongson.

I'm ok accepting patches without a second reviewer, but I advise for your own benefit to try to find someone who already knows the details of Loongson.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136578/new/

https://reviews.llvm.org/D136578