[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

WÁNG Xuěruì via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 24 00:07:26 PDT 2022


xen0n added a comment.

Hi, I've edited the summary and patch title for you. It's generally not necessary to add //that// much "politeness" when most of it is obvious from context (e.g. the fact that you're new face here, that there's obviously no LoongArch support in LLDB, and most of the methods being stubs). It didn't help that much of the text was in Chinglish either.

As for the changes, they look reasonable to me, but as I haven't tested it out myself yet (and unable to, due to it being stub-only), I'll not give the approval myself this time. Thanks for your contribution and welcome!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136578/new/

https://reviews.llvm.org/D136578



More information about the lldb-commits mailing list