[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.

> I expect the majority of places where we want to log to the diagnostic log channel to be places where we already log today.

This is my expectation too. Some logs are helpful for diagnosing problems, and having them already saved makes it easier for users to include info in their reports.



================
Comment at: lldb/source/Utility/Diagnostics.cpp:23
+static constexpr Log::Category g_categories[] = {
+    {{"lldb"}, {"diagnostics log for lldb"}, DiagnosticsLog::LLDB},
+};
----------------
To me, it's not ideal that there's an "lldb" channel, and this channel has an "lldb" category.

Do you have other categories in mind for later updates, that should be moved into this patch? For example, will there eventually be "warning" and "error" categories? If so, maybe start with those instead of "lldb".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135621/new/

https://reviews.llvm.org/D135621