[Lldb-commits] [PATCH] D135031: [lldb] [llgs] Move client-server communication into a separate thread (WIP)

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

FWIW, I tried the to run the benchmark on an apple machine and got roughly the same results (although I never managed to get it to run to completion). I also don't know how much of a deal that is. I think someone from Apple ought to comment on that.

However, I have to say that this API feels very unergonomic. I still haven't managed to figure out how is it supposed to work, much less where the bug is. I think it's just operating at too low level. Instead of dealing with selects and callbacks, I'd say that the interface between the threads should be "this is the packet I want you to send, and here's is how I would like to get the reply".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135031/new/

https://reviews.llvm.org/D135031