[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 marked 6 inline comments as done.
augusto2112 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:644
+       if (&comp_unit == extra.get())
+         return &m_compile_unit_infos[i];
   }
----------------
aprantl wrote:
> is std::find() shorter here?
I think it'd be worse, because we're comparing pointers so we'd need to pass in a lambda, which would make things more confusing imo (ditto for the next comment).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136114/new/

https://reviews.llvm.org/D136114