[Lldb-commits] [lldb] f477412 - [lldb-tests] Remove dubious standard library flag

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 18 10:52:41 PDT 2022


Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:50:31-04:00
New Revision: f477412685fe6bac49d3d080ba91896c28e62116

URL: https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c28e62116
DIFF: https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c28e62116.diff

LOG: [lldb-tests] Remove dubious standard library flag

The test currently sets `USE_LIBSTDCPP = 0`, which is curious given the
behavior of `and` and `or` in Makefiles (the contents of the variables
are not important). In particular, this causes the tests to not use the
standard libraries appropriately.

To capture the actual intent of the test, we're changing this to
`USE_LIBCXX=1`.

Differential Revision: https://reviews.llvm.org/D136171

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile b/lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile
index 6bfb97cd2c2bc..3966839e1f8a0 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/Makefile
@@ -1,7 +1,5 @@
 CXX_SOURCES := main.cpp
-USE_LIBSTDCPP := 0
-
-
+USE_LIBCPP := 1
 
 CXXFLAGS_EXTRAS := -O0
 include Makefile.rules


        


More information about the lldb-commits mailing list