[Lldb-commits] [lldb] 3c1d8e0 - [lldb-tests] Add compiler version check in TestFunctionStarts

[Felipe de Azevedo Piovezan via lldb-commits]

Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:48:26-04:00
New Revision: 3c1d8e06d4a995f8d421ede3cf9240bbddc43441

URL: https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbddc43441
DIFF: https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbddc43441.diff

LOG: [lldb-tests] Add compiler version check in TestFunctionStarts

This test requires compiling its input program without debug
information. To do so, it uses certain Makefile variables that are never
populated with custom libcxx paths (if present). Doing so would not
necessarily be correct: we cannot guarantee that said standard library
has no debug symbols.

As such, we keep using the system libraries but disable the tests in
clang versions that are too old to work with more modern system
libraries, as in the case of the lldb-matrix bot.

Differential Revision: https://reviews.llvm.org/D136178

Added: 
    

Modified: 
    lldb/test/API/macosx/function-starts/TestFunctionStarts.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/macosx/function-starts/TestFunctionStarts.py b/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
index 9b8ef06ac7eb0..f829c761bbd78 100644
--- a/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
+++ b/lldb/test/API/macosx/function-starts/TestFunctionStarts.py
@@ -17,6 +17,7 @@ class FunctionStartsTestCase(TestBase):
 
     @skipIfRemote
     @skipUnlessDarwin
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_function_starts_binary(self):
         """Test that we make synthetic symbols when we have the binary."""
         self.build(dictionary={'CODESIGN': ''}) # Binary is getting stripped later.
@@ -24,6 +25,7 @@ def test_function_starts_binary(self):
 
     @skipIfRemote
     @skipUnlessDarwin
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_function_starts_no_binary(self):
         """Test that we make synthetic symbols when we don't have the binary"""
         self.build(dictionary={'CODESIGN': ''}) # Binary is getting stripped later.