[Lldb-commits] [PATCH] D127695: [clang] Implement Template Specialization Resugaring

[John McCall via Phabricator via lldb-commits]

rjmccall added a comment.

I see, thank you. I know you've marked this a WIP, but it's always good to describe these things in the patch description; that's what it's for.

This is quite exciting!  Thank you for looking into this.

I think you could usefully be much more incremental here.  Obviously the resugaring transform is one big piece, but it's likely that you could usefully roll out the applications of it one at a time and see some incremental improvements, and it would be a lot easier for us to then review the changes you're needing to make to see why you're making them.  That shouldn't make it any more difficult to measure holistic things like the overall compile-time impact of resugaring — it's all filtering through a single place, so you ought to be able to easily disable it there.  You could also disable it by default by leaving it behind a `-cc1` flag that you only enable in your tests.  That would let you actually land the work incrementally, which I would have no objection to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127695/new/

https://reviews.llvm.org/D127695