[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1600
       // file and line that things are declared on.
-      std::string qualified_name;
-      if (die.GetQualifiedName(qualified_name))
-        unique_typename = ConstString(qualified_name);
+      unique_typename = ConstString(GetCPlusPlusQualifiedName(die));
       unique_decl.Clear();
----------------
Overall LGTM. Correct me if I missed something, but the main functional change is that previously when `GetQualifiedName` returned `nullptr` we didn't re-assign it to `unique_typename`. However, now we would unconditionally assign. Does that matter? Should we only re-assign if the string is non-empty? Or should we use some `Optional` type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135979/new/

https://reviews.llvm.org/D135979