[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 14 04:06:27 PDT 2022


Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:280
+
+  return {};
+}
----------------
labath wrote:
> I think this should return `basename` here. Otherwise, all non-templated names will match the empty string.
Very true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135921/new/

https://reviews.llvm.org/D135921



More information about the lldb-commits mailing list