[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 14 01:31:32 PDT 2022


DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.

This LGTM thanks for the fix just one comment on the test.



================
Comment at: lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16
+
+        self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY, substrs=["2 matches found", "\nid =", "\nid ="])
----------------
Could you match the whole string here? A bit easier to see at a glance that way. Unless the output is not stable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135827/new/

https://reviews.llvm.org/D135827



More information about the lldb-commits mailing list