[Lldb-commits] [PATCH] D135607: Summary:

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 11 09:36:16 PDT 2022


JDevlieghere added a comment.

In D135607#3848334 <https://reviews.llvm.org/D135607#3848334>, @HenriqueBucher wrote:

> To be frank, I think this formatting is silly and wrong now that I am looking at it. 
> Looking at the rendered markdown at Github <https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-vscode/README.md> you can see that the browser itself word wraps for you to the allocated width. 
> There is no need to break down manually. 
> However if you break down inside the tables it will break the syntax of markdown tables.

Yes, this is an example where you have to exceed the 80 column limit.

> And the wrapping does not affect at all the output on the web.

That's correct, the 80 column limit is not a technical limitation, but rather a coding documentation style one. If you take a look at the other docs you'll notice everything is using the 80 column limit.

> I'd say delete this patch and forget about this 80 column limit. 
> But it's up to you, I'm here just as a helper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135607/new/

https://reviews.llvm.org/D135607



More information about the lldb-commits mailing list